Skip to content

Commit

Permalink
Update comments to reflect our recent handling of "sneaky checked exc…
Browse files Browse the repository at this point in the history
…eptions."

(followup to cl/587701612)

RELNOTES=n/a
PiperOrigin-RevId: 627152987
  • Loading branch information
cpovirk authored and Google Java Core Libraries committed Apr 22, 2024
1 parent 38c8017 commit b9d2b93
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1298,8 +1298,7 @@ private static void executeListener(Runnable runnable, Executor executor) {
executor.execute(runnable);
} catch (Exception e) { // sneaky checked exception
// Log it and keep going -- bad runnable and/or executor. Don't punish the other runnables if
// we're given a bad one. We only catch RuntimeException because we want Errors to propagate
// up.
// we're given a bad one. We only catch Exception because we want Errors to propagate up.
log.get()
.log(
Level.SEVERE,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,7 @@ private static void executeListener(Runnable runnable, Executor executor) {
executor.execute(runnable);
} catch (Exception e) { // sneaky checked exception
// Log it and keep going -- bad runnable and/or executor. Don't punish the other runnables if
// we're given a bad one. We only catch RuntimeException because we want Errors to propagate
// up.
// we're given a bad one. We only catch Exception because we want Errors to propagate up.
log.get()
.log(
Level.SEVERE,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1298,8 +1298,7 @@ private static void executeListener(Runnable runnable, Executor executor) {
executor.execute(runnable);
} catch (Exception e) { // sneaky checked exception
// Log it and keep going -- bad runnable and/or executor. Don't punish the other runnables if
// we're given a bad one. We only catch RuntimeException because we want Errors to propagate
// up.
// we're given a bad one. We only catch Exception because we want Errors to propagate up.
log.get()
.log(
Level.SEVERE,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,7 @@ private static void executeListener(Runnable runnable, Executor executor) {
executor.execute(runnable);
} catch (Exception e) { // sneaky checked exception
// Log it and keep going -- bad runnable and/or executor. Don't punish the other runnables if
// we're given a bad one. We only catch RuntimeException because we want Errors to propagate
// up.
// we're given a bad one. We only catch Exception because we want Errors to propagate up.
log.get()
.log(
Level.SEVERE,
Expand Down

0 comments on commit b9d2b93

Please sign in to comment.