-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove a couple of APIs scheduled for removal in January 2018.
For other APIs scheduled for removal, give them a stay of execution until April so their existing usages can be cleaned up. Also update a few methods that were scheduled for removal in February to April, since we won't be doing @beta removals in February. ALSO update the java7 version of TreeTraveserTest to match changes that were made at some point in the past to the mainline version but not merged. RELNOTES: - `collect`: Removed `BinaryTreeTraverser`. - `concurrent`: Removed `Futures#dereference` and `MoreExecutors#sequentialExecutor`. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=182827661
- Loading branch information
Showing
20 changed files
with
53 additions
and
1,108 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
f91ef6c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow.
Futures.dereference()
wasn't deprecated in 23.0, and is gone in 24.0? Even the latest API docs for 23 do not mention the removal: https://google.github.io/guava/releases/23.0/api/docs/com/google/common/util/concurrent/Futures.html#dereference-com.google.common.util.concurrent.ListenableFuture-f91ef6c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was deprecated in 23.1, released September 27, before being removed in 24.0, released February 1. That was a difference of 4 months, clearing the 3 months that we aim for (but, I should note, don't guarantee) for changes to
@Beta
types.Deprecating an API in a minor version is what Semantic Versioning specifies.
f91ef6c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, but isn't it unfortunate that the latest published API docs still document this method, and do not mention any deprecation or pending removal?
f91ef6c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpovirk's link was to the 23.1 javadocs, which did deprecate. There were also javadocs published for 23.{1-6} published that all had it deprecated
f91ef6c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may be getting bit by our change to our version naming scheme:
If you start with the URL for 23.0...
https://google.github.io/guava/releases/23.0/api/docs/com/google/common/util/concurrent/Futures.html#dereference-com.google.common.util.concurrent.ListenableFuture-
...and bump the minor version number...
https://google.github.io/guava/releases/23.1/api/docs/com/google/common/util/concurrent/Futures.html#dereference-com.google.common.util.concurrent.ListenableFuture-
...you can get a 404, suggesting that the docs for 23.1 aren't available (or even that it hasn't been released). That's because the next version is called "23.1-jre":
https://google.github.io/guava/releases/23.1-jre/api/docs/com/google/common/util/concurrent/Futures.html#dereference-com.google.common.util.concurrent.ListenableFuture-
The docs for 23.1-jre through 23.6-jre have been linked from the home page under "Latest release" as each has become available.
f91ef6c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. Thanks for the explanation.