Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @Beta from RangeSet and RangeMap #3376

Closed
tyomka opened this issue Feb 6, 2019 · 17 comments
Closed

Remove @Beta from RangeSet and RangeMap #3376

tyomka opened this issue Feb 6, 2019 · 17 comments
Assignees
Labels
P3 package=collect status=triaged type=debeta Request to remove something from @Beta

Comments

@tyomka
Copy link

tyomka commented Feb 6, 2019

Range has been marked with @Beta since 10.0 (September 28, 2011).
RangeMap, RangeSet and their implementations since 14.0 (February 25, 2013).

I would like to propose to remove the @Beta annotation.

@kluever kluever added package=collect type=debeta Request to remove something from @Beta labels Feb 6, 2019
@kevinb9n
Copy link
Contributor

kevinb9n commented Feb 6, 2019

(The only part of Range that's still beta is asSet().) I feel like we should be able to take care of these in the next batch of debeta-ings.

@tyomka
Copy link
Author

tyomka commented Feb 8, 2019

@cpovirk
I've mistakenly assumed that Range is annotated with @Beta. It is not.
Still the issue context is still relevant for RangeMap and RangeSet.

@shashvat-kedia
Copy link

@tyomka Can I work on this?

@gskaplan
Copy link

Is there any update on this?

@prissky
Copy link

prissky commented May 13, 2020

Is there any news?

@ggarcia-te
Copy link

Any news about this?

@tyomka
Copy link
Author

tyomka commented Jun 29, 2020

Any news about this?

I'm kinda waiting for someone from the Guava team to validate my pull request. Is there anything i can do?

@kluever kluever changed the title Remove @Beta from Range and related classes Remove @Beta from RangeSet and RangeMap Jun 30, 2020
@julianhyde
Copy link

+1 to remove @Beta. Apache Calcite, as of release 1.26, relies on RangeSet (and it appears in the Calcite's public API in one place, class Sarg). We are prepared to shade, and break our API if it comes to that, because RangeSet is the perfect library for what we need. Some certainty would be appreciated. If RangeSet is going away we can make other plans.

@zabetak
Copy link

zabetak commented Sep 30, 2020

I can see that the issue is open for more than a year. Is the Guava team at least considering this request?

@mwunderlich
Copy link

Any updates on removing @beta for RangeMap (also applies to TreeRangeMap)?

@runnable-thread
Copy link

Any updates on removing @beta for RangeMap (also applies to TreeRangeMap)?

copybara-service bot pushed a commit that referenced this issue Apr 10, 2023
Fixes #3376 and #3380

RELNOTES=`collect`: Remove `@Beta` from `RangeMap`, `RangeSet`, and friends.
PiperOrigin-RevId: 523148423
@kluever
Copy link
Member

kluever commented Apr 10, 2023

This is now fixed.

@kluever kluever closed this as completed Apr 10, 2023
copybara-service bot pushed a commit that referenced this issue Apr 10, 2023
Fixes #3376 and #3380

RELNOTES=`collect`: Remove `@Beta` from `RangeMap`, `RangeSet`, and friends.
PiperOrigin-RevId: 523172033
@taomoh
Copy link

taomoh commented May 17, 2023

This is now fixed.

@kluever Do you know which version this fix is going to be released in?
Latest version 31.1-jre doesn't have it

@kluever
Copy link
Member

kluever commented May 17, 2023

It'll be in the next version of Guava --- I think @cpovirk was planning on cutting a release in the next few weeks?

@cpovirk
Copy link
Member

cpovirk commented May 18, 2023

Yes, maybe the end of next week if all goes well. If not, I'd hope the week after.

@julianhyde
Copy link

@cpovirk, It's helpful if you can state the release number when it will be fixed. Because many of us dependent issues and we want to write 'Fixed in Guava 32.0' and move on.

@cpovirk
Copy link
Member

cpovirk commented May 18, 2023

It will be 32.0.0. (Even though it will be a major-version bump, the release will probably not contain any breaking changes to Guava itself: It will just contain a small breaking change to the much less used guava-testlib, and we keep the version numbers of the two in sync.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 package=collect status=triaged type=debeta Request to remove something from @Beta
Projects
None yet
Development

Successfully merging a pull request may close this issue.

15 participants