-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove @Beta from remaining FluentFuture APIs #3419
Labels
Comments
copybara-service bot
pushed a commit
that referenced
this issue
Dec 13, 2021
… `addCallback`. This leaves `@Beta` only for the methods that remain `@Beta` in `Futures` itself, which I'm hoping to make some effort toward later this week. This CL is an admission that we're never going to get around to reworking `FluentFuture` to be more of a "builder," as discussed in #3419. Maybe there's still a place for something more builder-like, but there's no chance that we'll try to change `FluentFuture` in place. And probably we'll never do anything. RELNOTES=`util.concurrent`: Removed `@Beta` from the `FluentFuture` type, its factory methods, and `addCallback`. PiperOrigin-RevId: 416116755
copybara-service bot
pushed a commit
that referenced
this issue
Dec 13, 2021
… `addCallback`. This leaves `@Beta` only for the methods that remain `@Beta` in `Futures` itself, which I'm hoping to make some effort toward later this week. This CL is an admission that we're never going to get around to reworking `FluentFuture` to be more of a "builder," as discussed in #3419. Maybe there's still a place for something more builder-like, but there's no chance that we'll try to change `FluentFuture` in place. And probably we'll never do anything. RELNOTES=`util.concurrent`: Removed `@Beta` from the `FluentFuture` type, its factory methods, and `addCallback`. PiperOrigin-RevId: 416122526
Looks like most of this happened, The only remaining
What do we think about these, @cpovirk ? |
We can probably just remove
|
copybara-service bot
pushed a commit
that referenced
this issue
Apr 11, 2023
Fixes #3419 RELNOTES=`concurrent`: Remove `@Beta` from `FluentFuture`. PiperOrigin-RevId: 523456254
This is now fixed. |
copybara-service bot
pushed a commit
that referenced
this issue
Apr 11, 2023
Fixes #3419 RELNOTES=`concurrent`: Remove `@Beta` from `FluentFuture`. PiperOrigin-RevId: 523466140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Now that we changed the type hierarchy, I think there's not much blocking this, except:
Future
, more of a "builder." But it's hard to imagine that that would be a priority. [Edit: Part of the motivation here is that that would be a better model for attaching "interceptors," like for tracing.]The text was updated successfully, but these errors were encountered: