Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @Beta from FluentIterable.from(E[]) #3426

Closed
cpovirk opened this issue Mar 25, 2019 · 1 comment
Closed

Remove @Beta from FluentIterable.from(E[]) #3426

cpovirk opened this issue Mar 25, 2019 · 1 comment
Labels
P3 package=collect status=triaged type=debeta Request to remove something from @Beta

Comments

@cpovirk
Copy link
Member

cpovirk commented Mar 25, 2019

We already did this for from(Iterable).

As noted in #3425, we might have general reservations about committing to more FluentIterable methods now that Stream exists.

Aside from that, the only reservations I know of are:

  • Arguably "from" was the wrong name for this, since it reflects changes to the backing array. (But this is equally true of the Iterable overload.) We might have preferred "for" (though that's a keyword, so we'd have to pick a longer name...).
  • I think that it might not actually be truly 100% unmodifiable, since the returned iterator might be able to be cast to ListIterator, on which users could call set.
@cpovirk cpovirk added package=collect status=triaged P2 type=debeta Request to remove something from @Beta labels Mar 25, 2019
@kluever kluever added P3 and removed P2 labels Aug 13, 2019
copybara-service bot pushed a commit that referenced this issue Apr 10, 2023
Fixes #3426 and #3425

RELNOTES=`collect`: Remove `@Beta` from `FluentIterable` APIs.
PiperOrigin-RevId: 523181420
@kluever
Copy link
Member

kluever commented Apr 10, 2023

Apologies for the inexcusably long delay here. This is now fixed.

@kluever kluever closed this as completed Apr 10, 2023
copybara-service bot pushed a commit that referenced this issue Apr 10, 2023
Fixes #3426 and #3425

RELNOTES=`collect`: Remove `@Beta` from `FluentIterable` APIs.
PiperOrigin-RevId: 523202674
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 package=collect status=triaged type=debeta Request to remove something from @Beta
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants