Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The PSL has been not been updated for over 3 months #7268

Closed
1 task done
jerechenamz opened this issue Jun 21, 2024 · 4 comments
Closed
1 task done

The PSL has been not been updated for over 3 months #7268

jerechenamz opened this issue Jun 21, 2024 · 4 comments
Assignees
Labels

Comments

@jerechenamz
Copy link

Description

According to the file history of the PSL https://github.com/google/guava/commits/v33.2.0/guava/src/com/google/thirdparty/publicsuffix/PublicSuffixPatterns.java?before=73856da06403d5d087007d3924c168c822dea23c+35

It updates at least every 6 weeks, but it has been 3 months since this was updated. Do we know how long it will take until the PSL is updated?

Example

File history of the PSL https://github.com/google/guava/commits/v33.2.0/guava/src/com/google/thirdparty/publicsuffix/PublicSuffixPatterns.java?before=73856da06403d5d087007d3924c168c822dea23c+35

Expected Behavior

PSL is updated every 6 weeks.

Actual Behavior

PSL hasn't been updated for 3 months.

Packages

No response

Platforms

No response

Checklist

@jerechenamz jerechenamz added the type=defect Bug, not working as expected label Jun 21, 2024
@cpovirk
Copy link
Member

cpovirk commented Jul 11, 2024

Thanks for checking on this. The last I saw, the update had gotten hung up on a failure from a completely bogus test in another team's project, and they'd refused to take responsibility for fixing it. The person who was trying to submit the update then left for a long vacation.

We could eventually try to push this through ourselves, but I'm not sure when we'd get around for it. Are you mostly checking to make sure that the process will eventually be restored, or is the current lack of updates potentially causing problems (either from specific missing updates or from a general reliance on up-to-date info)? (In their case, this is more fodder for #475 and/or a more regular release cadence.)

@jerechenamz
Copy link
Author

Are you mostly checking to make sure that the process will eventually be restored, or is the current lack of updates potentially causing problems (either from specific missing updates or from a general reliance on up-to-date info)?

Really both, but more the latter. By using Guava, we would expect regular updates to the PSL on a set schedule. We are seeing changes over 3 months old on the PSL that are not reflected. This was brought to our attention when a specific update was missing in our software.

@cpovirk cpovirk added P2 and removed P3 labels Jul 29, 2024
@cpovirk
Copy link
Member

cpovirk commented Jul 29, 2024

Thanks.

It looks like the anonymous team I was implicitly blaming was the wrong anonymous team to blame. I think I have now tracked down the team actually responsible, and I've proposed a change to unblock the update.

@cpovirk cpovirk self-assigned this Jul 29, 2024
copybara-service bot pushed a commit that referenced this issue Jul 31, 2024
Fixes #7268

RELNOTES=n/a
PiperOrigin-RevId: 629692707
@cpovirk
Copy link
Member

cpovirk commented Aug 17, 2024

Two updates landed in time for https://github.com/google/guava/releases/tag/v33.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants