Unhandled overflow in the concat() method of per-type primitive utility classes
#3304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unexpected `NegativeArraySizeException` or `ArrayIndexOutOfBoundsException` if the input arrays contain too many elements. Added test cases to demonstrate both overflow cases. Possible fix is provided. In this commit only the module `guava` and only the utility class `Longs` is covered along with its unit tests. See google#3303
JakeWharton
reviewed
Oct 20, 2018
| for (long[] array : arrays) { | ||
| length += array.length; | ||
| } | ||
| long[] result = new long[length]; | ||
| checkNoOverflow(length); |
There was a problem hiding this comment.
I preferred to write a custom checker to provide
- a better description ("the total number of elements in the arrays must fit in an int" instead of "integer overflow")
- a better exception type (
IllegalArgumentExceptioninstead ofArithmeticException- I would be really confused seeingArithmeticExceptionafter concatenatinglongarrays)
… unexpected `NegativeArraySizeException` or `ArrayIndexOutOfBoundsException` if the input arrays contain too many elements. De-duplicate unit test code. See google#3303
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
concat()method in the per-type primitive utility classes throws unexpectedNegativeArraySizeExceptionorArrayIndexOutOfBoundsExceptionif the input arrays contain too many elements.Added test cases to demonstrate both overflow cases. A possible fix is provided.
In this commit, only the module
guavaand only the utility classLongsare covered along with the unit tests.See #3303