Migrate from @NullableDecl to @CheckForNull in the backport.
#5740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
We do so for a couple reasons: - We've gotten [requests to avoid it](google/truth#704) (and checker-compat-qual in general) before. - The Checker Framework defines it to have a different meaning than other nullness declaration annotations (as discussed in [this documentation's exception for the `org.checkerframework` package](https://checkerframework.org/manual/#faq-declaration-annotations-moved)), and I would guess that no other tools handle it accordingly. We mostly aren't using `@NullableDecl` nowadays, since we've migrated to jsr305 and checker-qual annotations. But some annotations remain, mostly in tests and testlib. RELNOTES=n/a PiperOrigin-RevId: 399231620
copybara-service
bot
force-pushed
the
test_399231620
branch
from
4318d28
to
422c9dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate from
@NullableDeclto@CheckForNullin the backport.We do so for a couple reasons:
org.checkerframeworkpackage), and I would guess that no other tools handle it accordingly.We mostly aren't using
@NullableDeclnowadays, since we've migrated to jsr305 and checker-qual annotations. But some annotations remain, mostly in tests and testlib.RELNOTES=n/a