stopTimers capture in ServiceManager #5903
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@netdpb @ben-manes please review this pull request. CLA check is passed for this. |
|
@netdpb can someone please help in reviewing/merging this PR |
|
Hi @ayushjais2654. Thanks for this work, but we have to make a decision on whether we want to suppor this feature (#5842) in Guava before we can merge an implementation. We'll discuss more today. |
|
sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes : #5842
This feature provide the stopTimers for the defined services in the ServiceManager somewhat similar to the com.google.common.util.concurrent.ServiceManager.ServiceManagerState#startupTimers.