Adjust the capacity computation in Maps.newHashMapWithExpectedSize.
#5980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
[This JDK change](openjdk/jdk@3e39304) fixed the computation used when the first write to a `HashMap` is `putAll(otherMap)`. Previously that would occasionally lead to an unnecessarily large internal table. That same computation was copied into `Maps.newHashMapWithExpectedSize`, so it should also be adjusted. Thanks to @XenoAmess for both the JDK fix and the fix here. Closes #5965. RELNOTES=`Maps.newHashMapWithExpectedSize` sometimes allocated maps that were larger than they needed to be. PiperOrigin-RevId: 436318398
copybara-service
bot
force-pushed
the
test_436318398
branch
2 times, most recently
from
ae46196
to
6ad621e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the capacity computation in
Maps.newHashMapWithExpectedSize.This JDK change fixed the computation used when the first write to a
HashMapisputAll(otherMap). Previously that would occasionally lead to an unnecessarily large internal table. That same computation was copied intoMaps.newHashMapWithExpectedSize, so it should also be adjusted.Thanks to @XenoAmess for both the JDK fix and the fix here.
Closes #5965.
RELNOTES=
Maps.newHashMapWithExpectedSizesometimes allocated maps that were larger than they needed to be.