#2130 - Stop skipping certain tests under Windows

[ineuwirth]

Some tests depended on Unix line ending, changing those to use System.lineSeparator() instead. Now they can run on Windows too.

[ineuwirth]

I have noticed in the CI script that android tests are not executed under Windows but it still looked better to keep the sources as close as possible. I guess you would have done it internally anyway.

[cpovirk]

Thanks!

I have noticed in the CI script that android tests are not executed under Windows but it still looked better to keep the sources as close as possible. I guess you would have done it internally anyway.

Perhaps surprisingly, there are several factors here :) The short answer is that we do want to keep them in sync but that it's simplest for you not to bother, as our automation all carry over the changes automatically (at least when they merge cleanly, as they do here).

(When we update both copies, then anyone who runs the Android tests under Windows (even though we don't do it under our CI) gets to run the tests. Plus, as you noted, keeping the sources in sync is itself an advantage.)

Anyway, there's no need to change anything here; I've already pulled this in. And like your other PR, this one will be re-created in another PR with the commit attributed to you.

(FYI, I'm backing out the new usage of String.join to maintain compatibility with ancient versions of Android. I could keep it in the mainline, backing it out only in the backport, but that would cut against the goal of keeping the two in sync.)

[ineuwirth]

Thank you for sharing the behind the scenes details about how you handle the android part!

[cpovirk]

And like your other PR, this one will be re-created in another PR with the commit attributed to you.

I'm sorry, I got it right for the other PR but messed it up for this one. (I had some trouble with our automation—related, I theorize but haven't checked, to Windows line endings in the patch!—and ended up putting together the commits myself, only to forget to modify the author line in the one.)

[ineuwirth]

No problem at all.