Fix Google-internal common.collect tests under an Android emulator.
#6652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_550670580
branch
from
6e323c7
to
ae91667
Compare
The primary change comes as a followup to cl/543468006: Now that the Google-internal `ImmutableTable` declares [methods with Java 8+ types in their signatures](#6567), we get a `NoClassDefFoundError` when performing reflection on the class under old Android emulators. We perform reflection only when (a) using `NullPointerTester` or (b) using serialization. So we (a) stop running `NullPointerTester` under an Android emulator (though we continue to run the same `guava-android` test under a JVM) and (b) specify a `serialVersionUID` so that serialization doesn't need to compute one. (Specifying `serialVersionUID` was our MO for a while. Perhaps we just got careless, and perhaps we should be more diligent. Alternatively, perhaps we should change the `serialVersionUID` every release or so so as to encourage people [not to persist serialized data](https://github.com/google/guava#important-warnings). I at least went to a tiny bit of effort to keep `guava-jre` and `guava-android` on different `serialVersionUID` values, though maybe that's more likely to cause needless trouble someday than to prevent it?) The other change is to avoid running another GC test under an Android emulator. We'd originally done this for one copy of `AbstractIteratorTester` in cl/444929745, but for whatever reason, we didn't need it for the other copy until (I assume) cl/546307327 and its switch to a different emulator version. RELNOTES=n/a PiperOrigin-RevId: 550670580
copybara-service
bot
changed the title
common.collect tests under an Android emulator.common.collect tests under an Android emulator.
copybara-service
bot
force-pushed
the
test_550670580
branch
2 times, most recently
from
b860d73
to
230b0cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Google-internal
common.collecttests under an Android emulator.The primary change comes as a followup to cl/543468006: Now that the Google-internal
ImmutableTabledeclares methods with Java 8+ types in their signatures, we get aNoClassDefFoundErrorwhen performing reflection on the class under old Android emulators. We perform reflection only when (a) usingNullPointerTesteror (b) using serialization. So we (a) stop runningNullPointerTesterunder an Android emulator (though we continue to run the sameguava-androidtest under a JVM) and (b) specify aserialVersionUIDso that serialization doesn't need to compute one. (SpecifyingserialVersionUIDwas our MO for a while. Perhaps we just got careless, and perhaps we should be more diligent. Alternatively, perhaps we should change theserialVersionUIDevery release or so so as to encourage people not to persist serialized data. I at least went to a tiny bit of effort to keepguava-jreandguava-androidon differentserialVersionUIDvalues, though maybe that's more likely to cause needless trouble someday than to prevent it?)The other change is to avoid running another GC test under an Android emulator. We'd originally done this for one copy of
AbstractIteratorTesterin cl/444929745, but for whatever reason, we didn't need it for the other copy until (I assume) cl/546307327 and its switch to a different emulator version.RELNOTES=n/a