Fix Files.createTempDir and FileBackedOutputStream under Windows _services_ (at least under JDK 9+), a rare use case.
#6730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
cpovirk
added a commit
that referenced
this pull request
Sep 26, 2023
Fix `Files.createTempDir` and `FileBackedOutputStream` under Windows _services_, a rare use case. Fixes #6634 Relevant to #2686 in that it shows that we would ideally run our Windows testing under both Java 8 *and* a newer version.... RELNOTES=`io`: Fixed `Files.createTempDir` and `FileBackedOutputStream` under [Windows _services_, a rare use case](#6634). PiperOrigin-RevId: 568604081
cpovirk
added a commit
that referenced
this pull request
Sep 26, 2023
…ting Fix `Files.createTempDir` and `FileBackedOutputStream` under Windows _services_, a rare use case. Fixes #6634 Relevant to #2686 in that it shows that we would ideally run our Windows testing under both Java 8 *and* a newer version.... RELNOTES=`io`: Fixed `Files.createTempDir` and `FileBackedOutputStream` under [Windows _services_, a rare use case](#6634). PiperOrigin-RevId: 568604081
copybara-service
bot
force-pushed
the
test_568604081
branch
2 times, most recently
from
0cd2b3a
to
fffa5a1
Compare
copybara-service
bot
changed the title
Files.createTempDir and FileBackedOutputStream under Windows _services_, a rare use case.Files.createTempDir and FileBackedOutputStream under Windows _services_ (at least under JDK 9+), a rare use case.
copybara-service
bot
force-pushed
the
test_568604081
branch
from
fffa5a1
to
ffb4a72
Compare
copybara-service
bot
force-pushed
the
test_568604081
branch
from
ffb4a72
to
f87f68c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Files.createTempDirandFileBackedOutputStreamunder Windows services (at least under JDK 9+), a rare use case.Fixes #6634
Relevant to #2686 in that it shows that we would ideally run our Windows testing under both Java 8 and a newer version....
RELNOTES=
io: FixedFiles.createTempDirandFileBackedOutputStreamunder Windows services, a rare use case. (The fix actually covers only Java 9+ because Java 8 would require an additional approach. Let us know if you need support under Java 8.)