Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make equals work when comparing a cartesianProduct against another Set. #6789

Closed
wants to merge 0 commits into from
Closed

Make equals work when comparing a cartesianProduct against another Set. #6789

wants to merge 0 commits into from

Conversation

copybara-service[bot]
Copy link
Contributor

Make equals work when comparing a cartesianProduct against another Set.

In 2012 the parent type of CartesianSet was changed from AbstractSet to ForwardingCollection, with the inadvertent effect that a CartesianSet can never compare equal to another Set unless that is also a CartesianSet.

Fixes #6780.

RELNOTES=n/a

@copybara-service copybara-service bot closed this Oct 17, 2023
@copybara-service copybara-service bot deleted the test_573517273 branch October 17, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CartesianSet.equals always returns false for other Set types
0 participants