-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make BloomFilter.bitSize() public #6923
base: master
Are you sure you want to change the base?
Conversation
@@ -214,7 +214,7 @@ public long approximateElementCount() { | |||
|
|||
/** Returns the number of bits in the underlying bit array. */ | |||
@VisibleForTesting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now that we've made it public should we remove the annotation?
The documentation states the following
Do not use this interface for public or protected declarations: it is a fig leaf for bad design, and it does not prevent anyone from using the declaration---and experience has shown that they will. If the method breaks the encapsulation of its class, then its internal representation will be hard to change. Instead, use RestrictedApiChecker , which enforces fine-grained visibility policies.
@@ -215,7 +215,7 @@ public long approximateElementCount() { | |||
|
|||
/** Returns the number of bits in the underlying bit array. */ | |||
@VisibleForTesting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
PR to fix issue - #6866