Reenable NullPointerTester tests for our internal Android-emulator testing.
#7223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…testing. We had disabled the tests in that environment because `NullPointerTester` performed reflection on types that contained `Collector`-based APIs. Since `Collector` wasn't available, the tests failed. But now, we've enabled library desugaring for our internal tests (though we continue not to _require_ library desugaring unless users actually use such APIs), so the tests can work again. (relevant to #6567) RELNOTES=n/a PiperOrigin-RevId: 634784425
copybara-service
bot
force-pushed
the
test_634770528
branch
from
8359c92
to
6dd1cb1
Compare
copybara-service
bot
closed this pull request by merging all changes
into
master
in
6dd1cb1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reenable
NullPointerTestertests for our internal Android-emulator testing.We had disabled the tests in that environment because
NullPointerTesterperformed reflection on types that containedCollector-based APIs. SinceCollectorwasn't available, the tests failed. But now, we've enabled library desugaring for our internal tests (though we continue not to require library desugaring unless users actually use such APIs), so the tests can work again.(relevant to #6567)
RELNOTES=n/a