Fix single | to || for conditional checks to comply with Java S2638 standard #7272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the Java S2638 standard, which recommends using the short-circuit operator || instead of the bitwise operator | for conditional checks. The following change was made:
Before:
if (localInputFuture == null | localExceptionType == null | localFallback == null // This check, unlike all the others, is a volatile read || isCancelled()) { return; }
After:
if (localInputFuture == null || localExceptionType == null || localFallback == null // This check, unlike all the others, is a volatile read || isCancelled()) { return; }
The use of || ensures that the evaluation short-circuits, improving performance and avoiding potential null pointer exceptions. This change helps to improve the safety and efficiency of the code by following recommended best practices.
Please review the changes and provide your feedback.