Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overwrite flag #171

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add overwrite flag #171

wants to merge 2 commits into from

Conversation

gtuk
Copy link

@gtuk gtuk commented Apr 3, 2017

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@gtuk
Copy link
Author

gtuk commented Apr 3, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@romainmenke
Copy link

romainmenke commented Apr 3, 2017

You can already achieve this behaviour by pointing the input and output args to the same file. IMHO adding this flag increases complexity of the cli without improving it.

@gtuk
Copy link
Author

gtuk commented Apr 3, 2017

You mean something like "guetzli beens.png" should automaticly create a compressed file called beens.jpg if there is not output file given?

@mgrhm
Copy link

mgrhm commented Apr 3, 2017

I disagree with @romainmenke on this one. Adding an overwrite flag does improve the program and its CLI, at the cost of only a small increase in complexity. It doesn't break default behaviour since it needs to be explicitly called. It's ideal for situations where a user wants to compress an existing JPG file without ending up with a second copy of the same image.

@romainmenke
Copy link

romainmenke commented Apr 4, 2017

@gtuk Try guetzli ./my_image.jpeg ./my_image.jpeg. Unless I am mistaken it will replace the original file with the output.

guetzli ./my_image.jpeg ./my_image.jpeg
vs
guetzli --overwrite ./my_image.jpeg

So this adds extra code that has to be maintained without adding functionality.

Such a flag would make sense in a program that does batch compressions and alters filenames to prevent overwrites. Since Guetzli does neither I personally don't really see the added value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants