Fix build for Bazel 0.25 and later #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new_http_archive rule has been replaced with just http_archive in recent versions of Bazel. See also https://stackoverflow.com/a/58291928. The last documentation that still includes new_http_archive is for version 0.22. [1] The first version where http_archive appears on the "Repository rules" page is Bazel version 0.25. [2] So I expect this makes the BUILD files compatible with Bazel 0.25 and later, but possibly earlier versions too. I tested with 0.29.1. [1]: https://docs.bazel.build/versions/0.22.0/be/workspace.html#new_http_archive [2]: https://docs.bazel.build/versions/0.25.0/repo/http.html#http_archive
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
The build failed, and the logs say this:
bazel: Java 1.8 is required to install this formula.
Install AdoptOpenJDK 8 with Homebrew Cask:
brew cask install homebrew/cask-versions/adoptopenjdk8
Error: An unsatisfied requirement failed this build.
So let's try that then.
|
Hi Ruud, thanks for these fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
new_http_archiverule has been replaced with justhttp_archivein recent versions of Bazel. See also https://stackoverflow.com/a/58291928.The last documentation that still includes
new_http_archiveis for version 0.22. The first version wherehttp_archiveappears on the "Repository rules" page is Bazel version 0.25. So I expect thismakes the
BUILDfiles compatible with Bazel 0.25 and later, but possibly earlier versions too. I tested with 0.29.1.