Moe Sync #1197
Merged
Moe Sync #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=203129518
|
@ronshapiro Thanks to asm 6.2 you can now also add to |
|
@mkurz it's on its way! Already submitted internally, it will be in the next sync |
|
@ronshapiro Great! |
|
Thanks for bringing that back up - I opened up
#1198 to track that specifically.
…On Fri, Jul 13, 2018 at 3:13 PM Matthias Kurz ***@***.***> wrote:
@ronshapiro <https://github.com/ronshapiro> Great!
What about that comment here
<#1169 (comment)>? Is
shading asm actually necessary anymore nowadays?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1197 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAwY3XMT1GdBYjI-Iww7DT34iDtLvQPUks5uGPE_gaJpZM4VPDO_>
.
|
|
@ronshapiro Great, thanks! |
Closed
|
FYI: asm 6.2.1 is available |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code has been reviewed and submitted internally. Feel free to discuss on the PR and we can submit follow-up changes as necessary.
Commits:
Update guice opensource asm dep to 6.2.
af1dc88
Fixes #1169