Moe Sync #1240
Merged
Moe Sync #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=237860437
…r ant so that we don't use it for anything other than javadoc & jdiff. A few of the libraries it depended on (jarjar, bnd) didn't work with java8 code. We don't really need ant (we just use it for javadocs & jdiffs right now, and theoretically those could move to mvn too if someone figures out how to do that). ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=238041337
Generated with refaster, with some manual touch-ups afterwards. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=238042288
…related code. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=238113224
…ontinue using reflection to access the private constructor for MethodHandles.Lookups. See #904 for more information on why we need that particular bit of reflection. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=238113953
*** Original change description *** Refactor code to use java8-isms. Generated with refaster, with some manual touch-ups afterwards. *** ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=238342841
Automated rollback of changelist 32fef20 *** Original change description *** Automated rollback of commit 37255a2 *** Original change description *** Refactor code to use java8-isms. Generated with refaster, with some manual touch-ups afterwards. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=238487042
…ageThat(). This replaces assertions of the form assertThat(e).hasMessage(...) and assertThat(e.getMessage()) with assertThat(e).hasMessageThat(). ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=239207405
------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=241190415
…code & detect that their binding isn't working because of this call should use @Bind(lazy=true) instead. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=241948208
mcculls
reviewed
Apr 8, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code has been reviewed and submitted internally. Feel free to discuss on the PR and we can submit follow-up changes as necessary.
Commits:
Change infrastructure to allow using java8-isms.
fd04a9e
Some more infrastructure changes to work w/ java8 code. Namely, neuter ant so that we don't use it for anything other than javadoc & jdiff. A few of the libraries it depended on (jarjar, bnd) didn't work with java8 code. We don't really need ant (we just use it for javadocs & jdiffs right now, and theoretically those could move to mvn too if someone figures out how to do that).
c09ba1d
Refactor code to use java8-isms.
Generated with refaster, with some manual touch-ups afterwards.
37255a2
Stop using reflection to handle java.util.Optional in OptionalBinder-related code.
e27d4c0
Stop using reflection to access MethodHandle MethodHandles.Lookups. Continue using reflection to access the private constructor for MethodHandles.Lookups. See https://github.com//issues/904 for more information on why we need that particular bit of reflection.
5058704
Automated rollback of commit 37255a2
*** Original change description ***
Refactor code to use java8-isms.
Generated with refaster, with some manual touch-ups afterwards.
32fef20
Roll forward of 37255a2
Automated rollback of changelist 32fef20
*** Original change description ***
Automated rollback of commit 37255a2
*** Original change description ***
Refactor code to use java8-isms.
Generated with refaster, with some manual touch-ups afterwards.
3f0dbb8
Refactor exception-message assertions to use ThrowableSubject.hasMessageThat(). This replaces assertions of the form assertThat(e).hasMessage(...) and assertThat(e.getMessage()) with assertThat(e).hasMessageThat().
70552b0
Add an Injector#getAllMembersInjectorInjectionPoints method.
a6293fb
Add a note in isTransparentProvider that folks who trace through the code & detect that their binding isn't working because of this call should use @Bind(lazy=true) instead.
7e7ac3e