arm64: fix the fpsmid context save/restore issue #4683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemin9538
force-pushed
the
lemin_fpsmid_fix
branch
from
614505b to
75c783b
Compare
current when save fpsmid register is using following instruction: # FMOVD Fx, 16*1(R0) this instruction will compiled to: # str Dx, [x0, google#16] Dx is 64bit fp register not 128bit, then upper 64bit data will be lossed, this will cause application meet many random crash issue. need use 128bit register Vx or Q0 to save and restore the fpsmid context. Signed-off-by: Min Le <lemin.lm@antgroup.com>
lemin9538
force-pushed
the
lemin_fpsmid_fix
branch
from
75c783b to
185b88e
Compare
|
Good job. |
|
Good work! This patch also fixed some random errors in video transcoding. |
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 7, 2020
current when save and restore fpsmid register is using following instruction: # FMOVD F0, 16*1(R0) this instruction will compiled to: # str d0, [x0, #16] D0 is a 64bit register not 128bit, then upper 64bit data are loss, which will cause application meet many random crash issue. need use 128bit register v0 or q0 to save the fpsmid context. seems golang do not support fpsmid well for arrch64, I do not find related instruction to do this work, so use WORD instead. FUTURE_COPYBARA_INTEGRATE_REVIEW=#4683 from lemin9538:lemin_fpsmid_fix 185b88e PiperOrigin-RevId: 341155522
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current when save and restore fpsmid register is using following
instruction:
this instruction will compiled to:
D0 is a 64bit register not 128bit, then upper 64bit data
are loss, which will cause application meet many random
crash issue. need use 128bit register v0 or q0 to save
the fpsmid context.
seems golang do not support fpsmid well for arrch64, I do not find related instruction to do this work, so use WORD instead.