Add app helper nodes actions screen to datalayer wear sample #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
yschimke
reviewed
Dec 20, 2023
datalayer/sample/wear/src/main/java/com/google/android/horologist/datalayer/sample/WearApp.kt
Outdated
Show resolved
Hide resolved
yschimke
reviewed
Dec 20, 2023
...va/com/google/android/horologist/datalayer/sample/screens/nodesactions/NodesActionsScreen.kt
Show resolved
Hide resolved
yschimke
reviewed
Dec 20, 2023
...va/com/google/android/horologist/datalayer/sample/screens/nodesactions/NodesActionsScreen.kt
Show resolved
Hide resolved
yschimke
approved these changes
Dec 20, 2023
|
In Node actions, why the big gap to the shrunken chip? |
I added the gap to easily see the difference between the items of the list of devices and a button that is not an item of that list. Maybe a header would do, but it seemed too much just for a single chip. I'm not UI expert so happy to hear suggestions. |
luizgrp
force-pushed
the
datalayer_wear_nodes_actions
branch
from
fd942b9
to
f933e11
Compare
I see there is no padding defined there, so not sure why it has a bigger gap, to be checked. |
|
Maybe a bug with SLC? or Horologist if it's doing that. |
|
Same with ChipCompact from wear-compose directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Add app helper nodes actions screen to datalayer wear sample.
WHY
Show case app helper features.
Checklist 📋