Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CustomMediaActionButton UI to be in line with MediaButton. #1950

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Update CustomMediaActionButton UI to be in line with MediaButton. #1950

merged 1 commit into from
Jan 10, 2024

Conversation

kpaikena
Copy link
Collaborator

@kpaikena kpaikena commented Jan 10, 2024 •
edited
Loading

WHAT

Update CustomMediaActionButton UI.

WHY

To align UI with other media buttons.

HOW

Changed default icon size, and use UnboundedRippleButton to show custom ripple.

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

yschimke
yschimke approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@yschimke yschimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised it isn't covered by a screenshot test

@yschimke yschimke merged commit cff83d7 into google:main Jan 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yschimke yschimke yschimke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpaikena @yschimke