Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Install App Prompt to dismiss bottomsheet when not now button is tapped #1971

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Update Install App Prompt to dismiss bottomsheet when not now button is tapped #1971

merged 1 commit into from
Jan 15, 2024

Conversation

luizgrp
Copy link
Member

@luizgrp luizgrp commented Jan 15, 2024

WHAT

Update Install App Prompt to dismiss bottomsheet when "not now" button is tapped.

WHY

Make the dismissal less abrupt, with animation.

Checklist 📋

  • [N/A] Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • [N/A] Update metalava's signature text files

@luizgrp luizgrp requested a review from kul3r4 January 15, 2024 08:34
@luizgrp luizgrp self-assigned this Jan 15, 2024
@luizgrp luizgrp requested a review from yschimke January 15, 2024 08:41
@luizgrp luizgrp merged commit 2617a2c into google:main Jan 15, 2024
4 checks passed
@luizgrp luizgrp deleted the datalayerphoneui_installappprompt_animatebsheetdismiss branch January 15, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yschimke yschimke yschimke approved these changes

@kul3r4 kul3r4 Awaiting requested review from kul3r4

Assignees

@luizgrp luizgrp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luizgrp @yschimke