Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove foreground check from sendRequestWithTimeout #1983

Conversation

luizgrp
Copy link
Member

@luizgrp luizgrp commented Jan 17, 2024

WHAT

Remove foreground check from sendRequestWithTimeout.

For future reference, it was added in #1728.

WHY

From @garanj:

I don't think the one in sendRequestWithTimeout should exist: There's nothing in that which requires a foreground for it to be valid request, where as (for example) starting a remote activity should have the foreground check. sendRequestWithTimeout could be used for use cases that don't need a foreground check.

Checklist 📋

  • [N/A] Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • [N/A] Update metalava's signature text files

@luizgrp luizgrp requested a review from garanj January 17, 2024 10:46
@luizgrp luizgrp self-assigned this Jan 17, 2024
@luizgrp luizgrp merged commit 25290b7 into google:main Jan 17, 2024
4 checks passed
@luizgrp luizgrp deleted the datalayercore_removefgcheck_sendRequestWithTimeout branch January 17, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants