Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve installOnNode kdocs and implementation #1989

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

luizgrp
Copy link
Member

@luizgrp luizgrp commented Jan 18, 2024

WHAT

Improve installOnNode kdocs and implementation.

WHY

Fixes #1902

  • In order to be explicit that exceptions should be handled.
  • In order to not fail silently when device type cannot be determined.
  • In order to not fail silently when app store uri is not supplied.

Checklist 📋

  • [N/A] Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • [N/A] Update metalava's signature text files

@luizgrp luizgrp requested a review from garanj January 18, 2024 11:17
@luizgrp luizgrp self-assigned this Jan 18, 2024
@luizgrp luizgrp requested a review from yschimke January 18, 2024 11:27
@luizgrp luizgrp merged commit fc1bb6a into google:main Jan 18, 2024
4 checks passed
@luizgrp luizgrp deleted the datalayer_installonnode_improve branch January 18, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve API and/or kdoc of installOnNode function
2 participants