Make counter sample consistent across phone and watch #1991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iption for counter sample
…ch description for counter sample" This reverts commit b3a9126.
luizgrp
reviewed
Jan 18, 2024
| @@ -72,7 +72,8 @@ | |||
| <!-- Counter screen --> | |||
| <string name="app_helper_counter_label">Counter: %1$s</string> | |||
| <string name="app_helper_counter_increase_btn_content_description">Increase counter</string> | |||
| <string name="app_helper_counter_increase_explanation">Open the datalayer sample on your watch to observe how the counter number is incremented</string> | |||
| <string name="app_helper_counter_message">Value: </string> | |||
There was a problem hiding this comment.
for proper translation, the placeholder for the value should be in the string definition, e.g.: Value: %1$s
| Text( | ||
| modifier = Modifier | ||
| .padding(16.dp), | ||
| text = stringResource(R.string.app_helper_counter_message) + state.counter, |
There was a problem hiding this comment.
after adding the placeholder to the string definition, this should be changed to:
text = stringResource(R.string.app_helper_counter_message, state.counter),
luizgrp
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Make counter sample consistent across phone and watch
WHY
To improve understanding of what the sample shows
HOW
Rename description and labels, use the same button
Checklist 📋