Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implementation of installOnNode for phones #1993

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

luizgrp
Copy link
Member

@luizgrp luizgrp commented Jan 18, 2024

WHAT

Fix implementation of installOnNode for phones.

WHY

On phone devices, it will always return STATUS_UNKNOWN

HOW

Checklist 📋

  • [N/A] Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • [N/A] Update metalava's signature text files

@luizgrp luizgrp self-assigned this Jan 18, 2024
@luizgrp luizgrp requested a review from yschimke January 18, 2024 17:29
@yschimke
Copy link
Collaborator

So not broken, just pointless to check?

@luizgrp
Copy link
Member Author

luizgrp commented Jan 18, 2024

So not broken, just pointless to check?

Yes, based on my understanding of the docs. Just when called by phones, for watches it is advised to check.

@luizgrp luizgrp merged commit 4699432 into google:main Jan 18, 2024
4 checks passed
@luizgrp luizgrp deleted the datalayer_installonnode_improve branch January 18, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants