Remove isNearby filter from AppHelper functions #2011
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Remove
isNearby
filter fromconnectedNodes
andconnectedAndInstalledNodes
functions from AppHelper.Add
isNearby
property toAppHelperNodeStatus
and update samples to display it.Phone sample
Screen_recording_20240126_165742.mp4
Wear sample
Screen_recording_20240129_110520.mp4
WHY
I think it was being used as a way to filter "connected" nodes, however, this is not correct.
Retrieving reachable nodes from
CapabilityClient
already returns nodes that are connected.IsNearby is only filtering by those connected directly to the caller device.
Use case which shows that it was not working as intended:
Expected result: watch device should be listed.
Actual result: watch device is not listed.
Checklist 📋