Update Confirmation to vertically center the contents #2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 26, 2024 13:53
…iations to handle more cases.
…ent, which is to vertically center the contents.
# Conflicts: # compose-material/src/main/java/com/google/android/horologist/compose/material/Confirmation.kt # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_alarmConfirmationScreen[0]_mobvoiticwatchpro5.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_alarmConfirmationScreen[1]_samsunggalaxywatch5.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_alarmConfirmationScreen[2]_samsunggalaxywatch6large.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_alarmConfirmationScreen[3]_googlepixelwatch.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_alarmConfirmationScreen[4]_genericsmallround.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_alarmConfirmationScreen[5]_genericlargeround.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_alarmConfirmationScreen[6]_smalldevicebigfonts.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_alarmConfirmationScreen[7]_largedevicesmallfonts.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_batterySaverScreen[0]_mobvoiticwatchpro5.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_batterySaverScreen[0]_mobvoiticwatchpro5_2.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_batterySaverScreen[1]_samsunggalaxywatch5.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_batterySaverScreen[1]_samsunggalaxywatch5_2.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_batterySaverScreen[2]_samsunggalaxywatch6large.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_batterySaverScreen[2]_samsunggalaxywatch6large_2.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_batterySaverScreen[3]_googlepixelwatch.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_batterySaverScreen[3]_googlepixelwatch_2.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_batterySaverScreen[4]_genericsmallround.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_batterySaverScreen[4]_genericsmallround_2.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_batterySaverScreen[5]_genericlargeround.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_batterySaverScreen[5]_genericlargeround_2.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_batterySaverScreen[6]_smalldevicebigfonts.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_batterySaverScreen[6]_smalldevicebigfonts_2.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_batterySaverScreen[7]_largedevicesmallfonts.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_batterySaverScreen[7]_largedevicesmallfonts_2.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_iconAndTextAlertScreen[0]_mobvoiticwatchpro5.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_iconAndTextAlertScreen[1]_samsunggalaxywatch5.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_iconAndTextAlertScreen[2]_samsunggalaxywatch6large.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_iconAndTextAlertScreen[3]_googlepixelwatch.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_iconAndTextAlertScreen[4]_genericsmallround.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_iconAndTextAlertScreen[5]_genericlargeround.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_iconAndTextAlertScreen[6]_smalldevicebigfonts.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_iconAndTextAlertScreen[7]_largedevicesmallfonts.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_textAlertScreen[0]_mobvoiticwatchpro5.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_textAlertScreen[1]_samsunggalaxywatch5.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_textAlertScreen[2]_samsunggalaxywatch6large.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_textAlertScreen[3]_googlepixelwatch.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_textAlertScreen[4]_genericsmallround.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_textAlertScreen[5]_genericlargeround.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_textAlertScreen[6]_smalldevicebigfonts.png # sample/src/test/snapshots/images/com.google.android.horologist.screensizes_DialogTest_textAlertScreen[7]_largedevicesmallfonts.png
…ent, which is to vertically center the contents.
yschimke
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
The Confirmation screen should have vertically centered contents
WHY
Contents were top aligned as per the Alert Dialog, now using the dialog defaults for confirmation screens by default.
HOW
Checklist 📋