Represent the invalid dates in DatePicker in grey color. #2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajat4064g
force-pushed
the
greypicker
branch
from
5be21a5
to
9d79e29
Compare
|
Can you add a test to com.google.android.horologist.screensizes.DatePickerTest that covers this? Would be good to see the result visually. But I'm probably not the right person to review. |
rajat4064g
force-pushed
the
greypicker
branch
from
9d79e29
to
9f60d5c
Compare
BowerSteve
reviewed
Feb 1, 2024
composables/src/main/java/com/google/android/horologist/composables/TimePicker.kt
Outdated
Show resolved
Hide resolved
composables/src/main/java/com/google/android/horologist/composables/DatePicker.kt
Show resolved
Hide resolved
composables/src/main/java/com/google/android/horologist/composables/DatePicker.kt
Outdated
Show resolved
Hide resolved
rajat4064g
force-pushed
the
greypicker
branch
2 times, most recently
from
35488ad
to
7ac2c6a
Compare
BowerSteve
approved these changes
Feb 2, 2024
rajat4064g
force-pushed
the
greypicker
branch
from
7ac2c6a
to
dcc2cad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Make the invalid dates (dates before fromDate and after toDate) visible in DatePicker but represent them in grey color.
This also solves the retaining of previous day value in the day picker if month picker is scrolled.
WHY
HOW
Checklist 📋