Add string resources for AI-UI module #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luizgrp
approved these changes
Feb 2, 2024
| public data class FailedResponseUiModel(public val message: String) : PromptOrResponseUiModel { | ||
| public companion object { | ||
| public val NoCompanion: FailedResponseUiModel = | ||
| FailedResponseUiModel("No companion app found") | ||
| public fun NoCompanion(context: Context): FailedResponseUiModel = |
There was a problem hiding this comment.
nit: usually it is avoided to pass reference of context to viewmodels in order to prevent further mistakes of holding an instance of it (which is not the case here)
There was a problem hiding this comment.
True, I guess to use this I'd have to implement AndroidViewModel which gets the application context.
There was a problem hiding this comment.
It's more a helper method, I might give it some thought and follow up just removing this, or moving to a Screen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Add string resources for AI-UI module
WHY
Good citizen
HOW
Checklist 📋