Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chip longClick, doubleClick #2028

Merged
merged 15 commits into from
Feb 13, 2024
Merged

Chip longClick, doubleClick #2028

merged 15 commits into from
Feb 13, 2024

Conversation

yschimke
Copy link
Collaborator

WHAT

Support for more click events types

WHY

#1822 (comment)

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

yschimke and others added 3 commits January 26, 2024 12:19
@yschimke
Combined Clickable
69a7ed2
@yschimke
Merge branch 'main' into combined_clickable
a546323 
# Conflicts:
#	compose-material/src/main/java/com/google/android/horologist/compose/material/Button.kt
@yschimke
Another attempt
81f39c6
@yschimke yschimke requested a review from Kpeved February 12, 2024 12:34
@yschimke yschimke closed this Feb 12, 2024
@yschimke yschimke reopened this Feb 12, 2024
@yschimke yschimke marked this pull request as ready for review February 13, 2024 11:54
@yschimke yschimke requested a review from garanj February 13, 2024 11:54
garanj
garanj approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@garanj garanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool

compose-material/src/test/java/com/google/android/horologist/compose/material/CardA11yTest.kt Show resolved Hide resolved
compose-material/src/test/java/com/google/android/horologist/compose/material/ChipA11yTest.kt Outdated Show resolved Hide resolved
@yschimke
Copy link
Collaborator Author

@garanj any advice on how to implement it without two a11y nodes?

@yschimke yschimke enabled auto-merge (squash) February 13, 2024 13:47
@yschimke yschimke merged commit 0b0e3f1 into google:main Feb 13, 2024
3 of 4 checks passed
@yschimke yschimke deleted the combined_clickable branch February 13, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kpeved Kpeved Kpeved left review comments

@garanj garanj garanj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yschimke @Kpeved @garanj