Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding device specific haptic constants for Samsung devices. #2035

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Adding device specific haptic constants for Samsung devices. #2035

merged 2 commits into from
Feb 16, 2024

Conversation

Kpeved
Copy link
Collaborator

@Kpeved Kpeved commented Feb 15, 2024

These constants should bring better alignment with views rotary experience

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@Kpeved Kpeved added the rotary_haptics Everything related to rotary and haptics label Feb 15, 2024
@yschimke
Copy link
Collaborator

Failing with

com.google.android.horologist.compose.rotaryinput.HapticsTest > testGalaxyWatch FAILED
    com.google.common.truth.ComparisonFailureWithFacts at HapticsTest.kt:131

com.google.android.horologist.compose.rotaryinput.HapticsTest > testGalaxyWatchClassic FAILED
    com.google.common.truth.ComparisonFailureWithFacts at HapticsTest.kt:119

@Kpeved
Adding device specific constants for Samsung devices.
4be7595 
These constants should bring better consistency with views rotary experience
@Kpeved
Adding device specific constants for Samsung devices.
01f81d1 
These constants should bring better consistency with views rotary experience
@Kpeved Kpeved merged commit 91b797b into google:main Feb 16, 2024
4 checks passed
yschimke pushed a commit to yschimke/horologist that referenced this pull request Feb 16, 2024
@Kpeved @yschimke
Adding device specific haptic constants for Samsung devices. (google#…
62077ff 
…2035)

* Adding device specific constants for Samsung devices.

These constants should bring better consistency with views rotary experience

(cherry picked from commit 91b797b)
Kpeved added a commit that referenced this pull request Feb 19, 2024
@yschimke @Kpeved
Adding device specific haptic constants for Samsung devices. (#2035) (#…
eea8e87 
…2037)

* Adding device specific constants for Samsung devices.

These constants should bring better consistency with views rotary experience

(cherry picked from commit 91b797b)

Co-authored-by: Mikhail Kulaha <michailkulaga@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yschimke yschimke yschimke approved these changes

Assignees

@yschimke yschimke

Labels
rotary_haptics Everything related to rotary and haptics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kpeved @yschimke