Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional padding at end of SLC #2045

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Additional padding at end of SLC #2045

merged 1 commit into from
Feb 19, 2024

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Feb 19, 2024 •
edited
Loading

WHAT

Default to an additional 10dp at end of responsive() to avoid clipping.
Can be overridden.

WHY

Clipping of a tall Card may lead to apps getting rejected.

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

BowerSteve
BowerSteve approved these changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@BowerSteve BowerSteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yschimke yschimke merged commit 9eb5ea3 into google:main Feb 19, 2024
4 checks passed
yschimke added a commit to yschimke/horologist that referenced this pull request Feb 20, 2024
@yschimke
Additional padding at end of list (google#2045)
ab22ed9 
(cherry picked from commit 9eb5ea3)
yschimke added a commit that referenced this pull request Feb 20, 2024
@yschimke
Additional padding at end of list (#2045) (#2047)
d4e9979 
(cherry picked from commit 9eb5ea3)
yschimke added a commit that referenced this pull request Feb 20, 2024
@yschimke
Revert "Additional padding at end of list (#2045) (#2047)"
4907f8a 
This reverts commit d4e9979.
yschimke added a commit that referenced this pull request Feb 20, 2024
@yschimke
Revert "Additional padding at end of list (#2045) (#2047)" (#2048)
f6cf2d3 
This reverts commit d4e9979.
yschimke added a commit that referenced this pull request Feb 20, 2024
@yschimke
[0.5.x] Additional padding at end of list (#2045) (#2049)
79c9a2a 
* Additional padding at end of list (#2045)

(cherry picked from commit 9eb5ea3)

* 🤖 Updates screenshots

---------

Co-authored-by: yschimke <yschimke@users.noreply.github.com>
@yschimke yschimke deleted the safe_padding branch March 14, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BowerSteve BowerSteve BowerSteve approved these changes

@ssancho14 ssancho14 Awaiting requested review from ssancho14

@kul3r4 kul3r4 Awaiting requested review from kul3r4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yschimke @BowerSteve