Updates AmbientAware to avoid recreating whole tree #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yschimke
reviewed
Feb 20, 2024
compose-layout/src/main/java/com/google/android/horologist/compose/ambient/AmbientAware.kt
Show resolved
Hide resolved
yschimke
approved these changes
Feb 20, 2024
yschimke
reviewed
Feb 20, 2024
|
|
||
| override fun onExitAmbient() { | ||
| ambientUpdate = AmbientStateUpdate(AmbientState.Interactive) | ||
| AmbientLifecycleObserver(activity, callback).also { |
There was a problem hiding this comment.
For the future, there is a comment that AmbientLifecycleObserver being mocked out.
Something we should consider for testing and previews.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Updates
AmbientAwareto avoid recreating whole tree (see issue #2041) - thanks to @marcin-adamczewskiWHY
Current implementation recreates whole tree when
isAlwaysOnScreenboolean changesHOW
Follow best practice for remembering always-on state
Checklist 📋