Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ResponsiveTimeText #2053

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Adds ResponsiveTimeText #2053

merged 1 commit into from
Feb 20, 2024

Conversation

garanj
Copy link
Collaborator

@garanj garanj commented Feb 20, 2024

WHAT

Adds ResponsiveTimeText to allow TimeText components to be easily set at 2.1% from top.

WHY

To help conform with larger devices.

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@garanj garanj requested a review from yschimke February 20, 2024 13:48
* Provides a [TimeText] component with a responsive padding of 2.1%.
*/
@Composable
public fun ResponsiveTimeText(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a follow up, can you make this the default in AppScaffold?

@yschimke yschimke merged commit 1363a17 into main Feb 20, 2024
4 checks passed
@yschimke yschimke deleted the responsive-time-text branch February 20, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants