Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with Firebase auth and FirebaseUrlFactory #2059

Merged
merged 6 commits into from
Feb 22, 2024
Merged

Fix issue with Firebase auth and FirebaseUrlFactory #2059

merged 6 commits into from
Feb 22, 2024

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Feb 22, 2024 •
edited
Loading

WHAT

Fix issue with Firebase auth and FirebaseUrlFactory.

WHY

Failing when clearing a header.

HOW

Treat null as removeHeader

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

luizgrp
luizgrp approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@luizgrp luizgrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - failing with metalava

@yschimke yschimke closed this Feb 22, 2024
@yschimke yschimke reopened this Feb 22, 2024
@yschimke yschimke merged commit 101ef64 into google:main Feb 22, 2024
4 checks passed
@yschimke yschimke deleted the Fix_http branch March 25, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizgrp luizgrp luizgrp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yschimke @luizgrp