Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Network Awareness doc #2065

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Improve Network Awareness doc #2065

merged 2 commits into from
Feb 23, 2024

Conversation

kul3r4
Copy link
Collaborator

@kul3r4 kul3r4 commented Feb 23, 2024

WHAT

Improve Network Awareness doc by adding links and small rephrasing

WHY

To make it easier to understand the role of this library

HOW

Added links, reworded

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

Copy link
Collaborator

@yschimke yschimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks.

docs/network-awareness.md Outdated Show resolved Hide resolved
@@ -64,13 +64,13 @@ public interface NetworkingRules {
}
```

It allow allows logging network usage and visibility into network status.
The library also allows logging network usage and visibility into network status.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to tie back this visibility to something user focused?

Like visually demonstrating why results may be stale? Or that only offline music is available?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, PTAL

@yschimke yschimke changed the title Improve Network Awarenes doc Improve Network Awareness doc Feb 23, 2024
Copy link
Collaborator

@yschimke yschimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kul3r4 kul3r4 merged commit 2dd61ba into google:main Feb 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants