-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Network Awareness doc #2065
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks.
docs/network-awareness.md
Outdated
@@ -64,13 +64,13 @@ public interface NetworkingRules { | |||
} | |||
``` | |||
|
|||
It allow allows logging network usage and visibility into network status. | |||
The library also allows logging network usage and visibility into network status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to tie back this visibility to something user focused?
Like visually demonstrating why results may be stale? Or that only offline music is available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
WHAT
Improve Network Awareness doc by adding links and small rephrasing
WHY
To make it easier to understand the role of this library
HOW
Added links, reworded
Checklist 📋