Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AppInstallationStatusNodeType.UNKNOWN #2073

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Remove AppInstallationStatusNodeType.UNKNOWN #2073

merged 1 commit into from
Feb 29, 2024

Conversation

luizgrp
Copy link
Member

@luizgrp luizgrp commented Feb 28, 2024

WHAT

Remove AppInstallationStatusNodeType.UNKNOWN.

WHY

It should not need based on current code: items in allInstalledNodes are either in installedPhoneNodes or installedWatchNodes.

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@luizgrp luizgrp self-assigned this Feb 28, 2024
@luizgrp luizgrp merged commit 1a5fb0f into google:main Feb 29, 2024
4 checks passed
@luizgrp luizgrp deleted the datalayer_nodetype_removeunknown branch February 29, 2024 08:10
kul3r4 pushed a commit to kul3r4/horologist-1 that referenced this pull request Feb 29, 2024
@luizgrp @kul3r4
Remove AppInstallationStatusNodeType.UNKNOWN (google#2073)
268fad5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yschimke yschimke yschimke approved these changes

Assignees

@luizgrp luizgrp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luizgrp @yschimke