Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make 24h TimePicker more responsive on larger screens. #2095

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Make 24h TimePicker more responsive on larger screens. #2095

merged 3 commits into from
Mar 6, 2024

Conversation

ssancho14
Copy link
Collaborator

WHAT

WHY

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

yschimke
yschimke approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@yschimke yschimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for screenshots

BowerSteve
BowerSteve reviewed Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@BowerSteve BowerSteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TimePickerWith12HourClock needs to be updated too

composables/src/main/java/com/google/android/horologist/composables/TimePicker.kt Show resolved Hide resolved
@yschimke yschimke closed this Mar 6, 2024
@yschimke yschimke reopened this Mar 6, 2024
@yschimke yschimke merged commit dfd2e9d into google:main Mar 6, 2024
4 checks passed
@ssancho14 ssancho14 deleted the picker2 branch March 6, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BowerSteve BowerSteve BowerSteve left review comments

@yschimke yschimke yschimke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ssancho14 @yschimke @BowerSteve