Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support RNG screenshots #2122

Merged
merged 10 commits into from
Mar 18, 2024
Merged

Support RNG screenshots #2122

merged 10 commits into from
Mar 18, 2024

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Mar 14, 2024 •
edited
Loading

WHAT

Copy the code from ComposeStarter, put it in a library form that can be used widely across samples for quick and effective screenshot testing.

WHY

Consistent screenshot testing.

HOW

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@yschimke yschimke closed this Mar 14, 2024
@yschimke yschimke reopened this Mar 14, 2024
@yschimke yschimke changed the title Testing RNG screenshots Support RNG screenshots Mar 14, 2024
@yschimke yschimke requested a review from garanj March 14, 2024 16:56
@yschimke yschimke marked this pull request as ready for review March 14, 2024 16:57
@yschimke
Copy link
Collaborator Author

@garanj Can you post review? I'd like to land and start using the preferred screenshot option here.

@yschimke yschimke merged commit 6e0b2f4 into google:main Mar 18, 2024
4 checks passed
@yschimke yschimke deleted the rns_screenshots branch March 18, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garanj garanj Awaiting requested review from garanj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yschimke