Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Large screen volume button #2123

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Large screen volume button #2123

merged 2 commits into from
Mar 14, 2024

Conversation

kpaikena
Copy link
Collaborator

@kpaikena kpaikena commented Mar 14, 2024 •
edited
Loading

WHAT

Update media settings buttons to be centered vertically.

WHY

To align media buttons with the large screens UX guidelines for media.

HOW

Set vertical alignment to center and constraint element to bottom guideline.

Checklist 📋

  • Add explicit visibility modifier and explicit return types for public declarations
  • Run spotless check
  • Run tests
  • Update metalava's signature text files

@kpaikena kpaikena merged commit 0f903e9 into google:main Mar 14, 2024
4 checks passed
@kpaikena kpaikena deleted the large_screen_volume_button branch May 29, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yschimke yschimke yschimke approved these changes

@fstanis fstanis Awaiting requested review from fstanis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpaikena @yschimke