Add datalayer to README. Move Tile name to constant.Add exception if version format is not correct. #2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…version format is not correct.
kul3r4
requested review from
luizgrp and
yschimke
and removed request for
luizgrp
yschimke
reviewed
Mar 18, 2024
yschimke
reviewed
Mar 18, 2024
| @@ -33,8 +33,7 @@ public class InstallTilePrompt(private val phoneDataLayerAppHelper: PhoneDataLay | |||
| * Returns a [AppHelperNodeStatus] that meets the criteria to show this prompt, otherwise | |||
| * returns null. | |||
| */ | |||
| private val tileName = "com.example.MediaPlayerTile" | |||
| public suspend fun shouldDisplayPrompt(): AppHelperNodeStatus? { | |||
| public suspend fun shouldDisplayPrompt(tileName: String): AppHelperNodeStatus? { | |||
yschimke
reviewed
Mar 18, 2024
| return AppHelperResultCode.APP_HELPER_RESULT_NO_COMPANION_FOUND | ||
| } catch (ex: Exception) { | ||
| when (ex) { | ||
| is PackageManager.NameNotFoundException, is IllegalArgumentException -> { |
There was a problem hiding this comment.
What about changing Version(version) to Version.parse(version) returning Version??
yschimke
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Add datalayer to README. Move Tile name to constant.Add exception if version format is not correct.
WHY
#2114
HOW
Checklist 📋