Picker #2330
Merged
Picker #2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Horizontal padding set to 5.2% Padding above and below picker is 4.dp on smaller screens (less than 225.dp) and 6.dp on bigger screens.
|
I think that test takes multiple screenshots, so the failure gets fixed one at a time. I should improve that. But rerun the fixup once more |
|
Will fix in a follow up |
yschimke
pushed a commit
to yschimke/horologist
that referenced
this pull request
Aug 20, 2024
* Visual update for pickers. Horizontal padding set to 5.2% Padding above and below picker is 4.dp on smaller screens (less than 225.dp) and 6.dp on bigger screens. --------- Co-authored-by: ssancho14 <ssancho14@users.noreply.github.com> (cherry picked from commit c5f962a)
4 tasks
yschimke
added a commit
that referenced
this pull request
Aug 20, 2024
* Reduce spacing between icon and title on Confirmation to 8dp (was 12dp) BUG: 352551711 * Update Confirmation layout (#2327) (cherry picked from commit 1ae64ea) * Picker (#2330) * Visual update for pickers. Horizontal padding set to 5.2% Padding above and below picker is 4.dp on smaller screens (less than 225.dp) and 6.dp on bigger screens. --------- Co-authored-by: ssancho14 <ssancho14@users.noreply.github.com> (cherry picked from commit c5f962a) * Dialog 2: Dialog Harder (#2343) * Update dialogs following validation. Top & bottom padding to be percent based (14.56% and 20.83% respectively). Add 4.dp extra below the Title if there is no message. Bug: http://b/352552040 --------- Co-authored-by: ssancho14 <ssancho14@users.noreply.github.com> Co-authored-by: Yuri Schimke <yuri@schimke.ee> (cherry picked from commit 6c92d68) * Update ReponsiveTimeText to 0dp, which simulates 2dp * Cherry pick specific fixes from #2342 --------- Co-authored-by: stevebower <stevebower@google.com> Co-authored-by: ssancho14 <50666481+ssancho14@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Picker updates
WHY
HOW
Checklist 📋