Bug Fix : Observed Talkback Doesn't Announces Increase/Decrease Volume as "Buttons" #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yschimke
reviewed
Oct 7, 2024
| @@ -231,7 +233,7 @@ public object VolumeScreenDefaults { | |||
| @Composable | |||
| public fun IncreaseIcon() { | |||
| Icon( | |||
| modifier = Modifier.size(26.dp), | |||
| modifier = Modifier.size(26.dp).semantics { role = Role.Button }, | |||
There was a problem hiding this comment.
Icon itself isn't a button. Shouldn't Stepper (Wear Compose) handle this?
We wrap it slightly, but called here.
There was a problem hiding this comment.
Stepper is not handing this. Default implementation of Increase Icon and decrease Icon description doesn't fulfill our requirement.
There was a problem hiding this comment.
No objection to landing this, but we should probably track a bug in Wear Compose to fix this, and revert once it happens.
yschimke
changed the title
yschimke
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Added Semantic type to icon in VolumeScreen
WHY
Accessibility fix
HOW
Checklist 📋