New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring UI models module #2428

Merged

yschimke merged 8 commits into google:main from niting1112:refactoring_ui_models_module

Oct 18, 2024

Collaborator

niting1112 commented Oct 17, 2024 •

edited

Loading

WHAT

WHY

HOW

Checklist 📋

Add explicit visibility modifier and explicit return types for public declarations
Run spotless check
Run tests
Update metalava's signature text files

niting1112 added 2 commits

October 17, 2024 07:33


          create audio-ui-model module

bed2d6a


          create ui-model module

c1e86c7

yschimke reviewed

View reviewed changes

media/audio-ui-model/build.gradle.kts Outdated Show resolved Hide resolved

yschimke reviewed

View reviewed changes

media/audio-ui-model/build.gradle.kts Outdated Show resolved Hide resolved

yschimke reviewed

View reviewed changes

media/audio-ui-model/proguard-rules.pro Outdated Show resolved Hide resolved

yschimke reviewed

View reviewed changes

.../audio-ui-model/src/main/java/com/google/android/horologist/audio/ui/RotaryVolumeControls.kt Outdated Show resolved Hide resolved

yschimke reviewed

View reviewed changes

media/audio-ui/build.gradle.kts Outdated Show resolved Hide resolved

yschimke reviewed

View reviewed changes

media/sample/proguard-rules.pro Show resolved Hide resolved

yschimke reviewed

View reviewed changes

media/ui-model/build.gradle.kts Outdated Show resolved Hide resolved

yschimke reviewed

View reviewed changes

...a/ui/src/test/java/com/google/android/horologist/media/ui/screens/player/PlayerScreenTest.kt Outdated Show resolved Hide resolved

yschimke reviewed

View reviewed changes

media/ui-model/proguard-rules.pro Outdated Show resolved Hide resolved

niting1112 added 4 commits

October 17, 2024 12:46


          create ui-model module

86a36b2


          Merge remote-tracking branch 'my_origin/refactoring_ui_models_module'…

6c81e75

… into refactoring_ui_models_module

# Conflicts:
#	media/ui-model/build.gradle.kts
#	media/ui-model/src/main/AndroidManifest.xml
#	media/ui/build.gradle.kts
#	sample/build.gradle.kts
#	settings.gradle.kts


          Merge remote-tracking branch 'my_origin/refactoring_ui_models_module'…

8cb5f04

… into refactoring_ui_models_module


          Merge remote-tracking branch 'my_origin/refactoring_ui_models_module'…

e3b35e3

… into refactoring_ui_models_module

niting1112 marked this pull request as draft

October 17, 2024 13:18

niting1112 force-pushed the refactoring_ui_models_module branch 4 times, most recently from 60cd26b to 6a9457f Compare

October 17, 2024 13:54

niting1112 marked this pull request as ready for review

October 17, 2024 14:08


          revert unwanted changes in .idea files

36c755f

niting1112 force-pushed the refactoring_ui_models_module branch from 6a9457f to 36c755f Compare

October 17, 2024 14:13


          Merge branch 'main' into refactoring_ui_models_module

bf0dd1a

yschimke approved these changes

View reviewed changes

yschimke merged commit bde87db into google:main

6 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet