Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Player screen margins #2432

Merged
merged 8 commits into from
Oct 24, 2024
Merged

Update Player screen margins #2432

merged 8 commits into from
Oct 24, 2024

Conversation

martenxi
Copy link
Collaborator

Update Player Screen margins to match new UX specs.

This is primarily to allow the bottom buttons of the Player Screen to not sit on the border of the tap target.

@martenxi martenxi changed the title Patch 2 Update player screen. Oct 23, 2024
@martenxi martenxi changed the title Update player screen. Update player screen margins. Oct 23, 2024
@martenxi martenxi changed the title Update player screen margins. Update Player screen margins Oct 24, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks clipped.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @kul3r4 it sounds like some following fixes with correct this, but needed for an import.

@martenxi martenxi enabled auto-merge (squash) October 24, 2024 13:49
@martenxi martenxi merged commit aa9e060 into google:main Oct 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants