Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mac test runner #268

Closed
jwhpryor opened this issue Mar 18, 2024 · 2 comments
Closed

Add Mac test runner #268

jwhpryor opened this issue Mar 18, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone
Release 1.1

Comments

@jwhpryor
Copy link
Collaborator

Mac currently has issues running tests that need to be solved by migrating to at least Bazel 7.0.1.

Code currently compiles and runs, but java tests fail because of bazelbuild/bazel#16421.

The most straightforward fix is to migrate to Bazel 7.0.1, so for now this is blocked by #253.
@jwhpryor jwhpryor added this to the Release 1.1 milestone Mar 18, 2024
@jwhpryor jwhpryor added the enhancement New feature or request label Mar 18, 2024
@jwhpryor
Copy link
Collaborator Author

Frustratingly, this still isn't possible after moving to Bazel 7.0.2 due to #268.

I can't find a way to resolve this, and I think I'm convinced this is a failure in Bazel or one of its dependencies.

Sadly, the best I can do is a subset of the full test set. Hopefully someone from Bazel or GitHub will be able to help me resolve the issue.

copybara-service bot pushed a commit that referenced this issue Apr 21, 2024
@jwhpryor @copybara-github
Add Darwin runner for subset of targets.
3eae25f 
There is further discussion in
    - https://github.com/orgs/community/discussions/118963
    - #268

PiperOrigin-RevId: 610234559
@copybara-service copybara-service bot mentioned this issue Apr 21, 2024
Closed
copybara-service bot pushed a commit that referenced this issue Apr 21, 2024
@jwhpryor @copybara-github
Add Darwin runner for subset of targets.
927576a 
There is further discussion in
    - https://github.com/orgs/community/discussions/118963
    - #268

PiperOrigin-RevId: 610234559
copybara-service bot pushed a commit that referenced this issue Apr 22, 2024
@jwhpryor @copybara-github
Add Darwin runner for subset of targets.
934f93c 
There is further discussion in
    - https://github.com/orgs/community/discussions/118963
    - #268

PiperOrigin-RevId: 610234559
copybara-service bot pushed a commit that referenced this issue Apr 22, 2024
@jwhpryor @copybara-github
Add Darwin runner for subset of targets.
d6f92fa 
There is further discussion in
    - https://github.com/orgs/community/discussions/118963
    - #268

PiperOrigin-RevId: 610234559
copybara-service bot pushed a commit that referenced this issue Apr 22, 2024
@jwhpryor @copybara-github
Add Darwin runner for subset of targets.
8f1e4ef 
There is further discussion in
    - https://github.com/orgs/community/discussions/118963
    - #268

PiperOrigin-RevId: 610234559
copybara-service bot pushed a commit that referenced this issue Apr 22, 2024
@jwhpryor @copybara-github
Add Darwin runner for subset of targets.
9bcf668 
There is further discussion in
    - https://github.com/orgs/community/discussions/118963
    - #268

PiperOrigin-RevId: 610234559
copybara-service bot pushed a commit that referenced this issue Apr 22, 2024
@jwhpryor @copybara-github
Add Darwin runner for subset of targets.
fbc4f19 
There is further discussion in
    - https://github.com/orgs/community/discussions/118963
    - #268

PiperOrigin-RevId: 610234559
copybara-service bot pushed a commit that referenced this issue Apr 22, 2024
@jwhpryor @copybara-github
Add Darwin runner for subset of targets.
3a2711f 
There is further discussion in
    - https://github.com/orgs/community/discussions/118963
    - #268

PiperOrigin-RevId: 610234559
copybara-service bot pushed a commit that referenced this issue Apr 29, 2024
@jwhpryor @copybara-github
Add Darwin runner for subset of targets.
a500d88 
There is further discussion in
    - https://github.com/orgs/community/discussions/118963
    - #268

PiperOrigin-RevId: 610234559
copybara-service bot pushed a commit that referenced this issue May 3, 2024
@jwhpryor @copybara-github
Add Darwin runner for subset of targets.
ebbf66e 
There is further discussion in
    - https://github.com/orgs/community/discussions/118963
    - #268

PiperOrigin-RevId: 610234559
copybara-service bot pushed a commit that referenced this issue May 3, 2024
@jwhpryor @copybara-github
Add Darwin runner for subset of targets.
c6460c4 
There is further discussion in
    - https://github.com/orgs/community/discussions/118963
    - #268

PiperOrigin-RevId: 610234559
copybara-service bot pushed a commit that referenced this issue May 3, 2024
@jwhpryor @copybara-github
Add Darwin runner for subset of targets.
ca13971 
There is further discussion in
    - https://github.com/orgs/community/discussions/118963
    - #268

PiperOrigin-RevId: 610234559
copybara-service bot pushed a commit that referenced this issue May 3, 2024
@jwhpryor @copybara-github
Add Darwin runner for subset of targets.
7ee4620 
There is further discussion in
    - https://github.com/orgs/community/discussions/118963
    - #268

PiperOrigin-RevId: 610234559
copybara-service bot pushed a commit that referenced this issue May 3, 2024
@jwhpryor @copybara-github
Add Darwin runner for subset of targets.
455081d 
There is further discussion in
    - https://github.com/orgs/community/discussions/118963
    - #268

PiperOrigin-RevId: 610234559
copybara-service bot pushed a commit that referenced this issue May 3, 2024
@jwhpryor @copybara-github
Add Darwin runner for subset of targets.
5408342 
There is further discussion in
    - https://github.com/orgs/community/discussions/118963
    - #268

PiperOrigin-RevId: 610234559
copybara-service bot pushed a commit that referenced this issue May 3, 2024
@jwhpryor @copybara-github
Add Darwin runner for subset of targets.
eb1b1e6 
There is further discussion in
    - https://github.com/orgs/community/discussions/118963
    - #268

PiperOrigin-RevId: 610234559
copybara-service bot pushed a commit that referenced this issue May 3, 2024
@jwhpryor @copybara-github
Add Darwin runner for subset of targets.
496ccde 
There is further discussion in
    - https://github.com/orgs/community/discussions/118963
    - #268

PiperOrigin-RevId: 610234559
copybara-service bot pushed a commit that referenced this issue May 3, 2024
@jwhpryor @copybara-github
Add Darwin runner for subset of targets.
e43dde6 
There is further discussion in
    - https://github.com/orgs/community/discussions/118963
    - #268

PiperOrigin-RevId: 610234559
copybara-service bot pushed a commit that referenced this issue May 3, 2024
@jwhpryor @copybara-github
Add Darwin runner for subset of targets.
4cb91ca 
There is further discussion in
    - https://github.com/orgs/community/discussions/118963
    - #268

PiperOrigin-RevId: 610234559
copybara-service bot pushed a commit that referenced this issue May 3, 2024
@jwhpryor @copybara-github
Add Darwin runner for subset of targets.
f3d3bd6 
There is further discussion in
    - https://github.com/orgs/community/discussions/118963
    - #268

PiperOrigin-RevId: 630487313
@jwhpryor
Copy link
Collaborator Author

jwhpryor commented May 6, 2024

I unfortunately could never make this pass fully despite this working properly. I'm not a Bazel expert but I think I have a Bazel misconfiguration or there's a bug in Bazel. A small subset of tests are working.

@jwhpryor jwhpryor closed this as completed May 6, 2024